Open
Conversation
aaronpk
approved these changes
Nov 25, 2025
|
This PR is a bit confusing. I see @pcarleton's initial comment that we should be talking about client credentials and not the "client secret", but the PR itself only changes the URL that is referred to from the client secret section. The section referred to from line 61 in this PR doesn't actually talk about "Clients use a Client Secret transmitted in the request content " as the text before the link says. Am I missing something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oauth 2.1 2.4.1 is about client id and secret:
https://www.ietf.org/archive/id/draft-ietf-oauth-v2-1-13.html#section-2.4.1
But I think we want to explicitly reference the Client Credentials grant in 4.2: